Allow embedding dynamic config in static config #6573
Draft
+104
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Sep 27, 2024
| @@ -103,6 +105,21 @@ func Load(env string, configDir string, zone string, config interface{}) error { | |||
| } | |||
| } | |||
|
|
|||
| // Inject self-dynamic-config-client if dynamicConfig section present. | |||
| if config.DynamicConfig != nil { | |||
| if config.DynamicConfigClient == nil { | |||
There was a problem hiding this comment.
When is it okay for this not to be nil if dynamic config is specified here?
There was a problem hiding this comment.
I made it allowed to leave out dynamicConfigClient.. the only thing in there is pollInterval, if that's zero it'll just not do the refresh loop.
There was a problem hiding this comment.
Oh your question was the opposite. Then the answer is: there should be a way to specify nonzero pollInterval if you want to get updates. It's easiest to just use the existing setting.
|
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
PoC for #6561:
dynamicConfig, use the contents of that as dynamic config.dynamicConfigClient.pollIntervalis allowed to be zero, meaning "do not reload".This only works with configs loaded from yaml files, not generated by code and passed with WithConfig. Callers can use WithDynamicConfigClient with a StaticClient or MemoryClient.
Why?
Simplify server configuration for dev/test servers.
How did you test it?
unit tests, manual test of dev server (not cli)